[llvm] r238155 - Insert MCSectionData into the section list directly in getOrCreateSectionData.

Rafael Espindola rafael.espindola at gmail.com
Mon May 25 13:39:24 PDT 2015


Author: rafael
Date: Mon May 25 15:39:23 2015
New Revision: 238155

URL: http://llvm.org/viewvc/llvm-project?rev=238155&view=rev
Log:
Insert MCSectionData into the section list directly in getOrCreateSectionData.

Removing the logic from the constructor will make it easier to merge
MCSectionData and MCSection.

Modified:
    llvm/trunk/include/llvm/MC/MCAssembler.h
    llvm/trunk/lib/MC/MCAssembler.cpp

Modified: llvm/trunk/include/llvm/MC/MCAssembler.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCAssembler.h?rev=238155&r1=238154&r2=238155&view=diff
==============================================================================
--- llvm/trunk/include/llvm/MC/MCAssembler.h (original)
+++ llvm/trunk/include/llvm/MC/MCAssembler.h Mon May 25 15:39:23 2015
@@ -566,7 +566,7 @@ private:
 public:
   // Only for use as sentinel.
   MCSectionData();
-  MCSectionData(MCSection &Section, MCAssembler *A = nullptr);
+  MCSectionData(MCSection &Section);
 
   MCSection &getSection() const { return *Section; }
 
@@ -971,8 +971,10 @@ public:
 
     if (Created)
       *Created = !Entry;
-    if (!Entry)
-      Entry = new MCSectionData(Section, this);
+    if (!Entry) {
+      Entry = new MCSectionData(Section);
+      Sections.push_back(Entry);
+    }
 
     return *Entry;
   }

Modified: llvm/trunk/lib/MC/MCAssembler.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAssembler.cpp?rev=238155&r1=238154&r2=238155&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCAssembler.cpp (original)
+++ llvm/trunk/lib/MC/MCAssembler.cpp Mon May 25 15:39:23 2015
@@ -292,11 +292,7 @@ MCEncodedFragmentWithFixups::~MCEncodedF
 
 MCSectionData::MCSectionData() : Section(nullptr) {}
 
-MCSectionData::MCSectionData(MCSection &Section, MCAssembler *A)
-    : Section(&Section) {
-  if (A)
-    A->getSectionList().push_back(this);
-}
+MCSectionData::MCSectionData(MCSection &Section) : Section(&Section) {}
 
 MCSectionData::iterator
 MCSectionData::getSubsectionInsertionPoint(unsigned Subsection) {





More information about the llvm-commits mailing list