[llvm] r238132 - Refactor: Simplify boolean conditional return statements in llvm/lib/DebugInfo/DWARF

[Benjamin Kramer]

Author: d0k
Date: Mon May 25 08:28:03 2015
New Revision: 238132

URL: http://llvm.org/viewvc/llvm-project?rev=238132&view=rev
Log:
Refactor: Simplify boolean conditional return statements in llvm/lib/DebugInfo/DWARF

Use clang-tidy to simplify boolean conditional return statements. Patch by
Richard Thomson <legalize at xmission.com>!

Differential Revision: http://reviews.llvm.org/D9972

Modified:
    llvm/trunk/lib/DebugInfo/DWARF/DWARFFormValue.cpp
    llvm/trunk/lib/DebugInfo/DWARF/DWARFUnit.cpp

Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFFormValue.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFFormValue.cpp?rev=238132&r1=238131&r2=238132&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/DWARF/DWARFFormValue.cpp (original)
+++ llvm/trunk/lib/DebugInfo/DWARF/DWARFFormValue.cpp Mon May 25 08:28:03 2015
@@ -127,10 +127,8 @@ bool DWARFFormValue::isFormClass(DWARFFo
   // In DWARF3 DW_FORM_data4 and DW_FORM_data8 served also as a section offset.
   // Don't check for DWARF version here, as some producers may still do this
   // by mistake.
-  if ((Form == DW_FORM_data4 || Form == DW_FORM_data8) &&
-      FC == FC_SectionOffset)
-    return true;
-  return false;
+  return (Form == DW_FORM_data4 || Form == DW_FORM_data8) &&
+         FC == FC_SectionOffset;
 }
 
 bool DWARFFormValue::extractValue(DataExtractor data, uint32_t *offset_ptr,

Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFUnit.cpp?rev=238132&r1=238131&r2=238132&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/DWARF/DWARFUnit.cpp (original)
+++ llvm/trunk/lib/DebugInfo/DWARF/DWARFUnit.cpp Mon May 25 08:28:03 2015
@@ -79,10 +79,7 @@ bool DWARFUnit::extractImpl(DataExtracto
     return false;
 
   Abbrevs = Abbrev->getAbbreviationDeclarationSet(AbbrOffset);
-  if (Abbrevs == nullptr)
-    return false;
-
-  return true;
+  return Abbrevs != nullptr;
 }
 
 bool DWARFUnit::extract(DataExtractor debug_info, uint32_t *offset_ptr) {