[PATCH] Refactor: Simplify boolean conditional return statements in lib/AsmParser
Rafael EspĂndola
rafael.espindola at gmail.com
Mon May 25 05:01:16 PDT 2015
LGTM
On 25 May 2015 at 02:40, Richard <legalize at xmission.com> wrote:
> Hi dexonsmith, void, sunfish, rafael, resistor,
>
> Use clang-tidy to simplify boolean conditional return statements.
>
> http://reviews.llvm.org/D9968
>
> Files:
> lib/AsmParser/LLParser.cpp
>
> Index: lib/AsmParser/LLParser.cpp
> ===================================================================
> --- lib/AsmParser/LLParser.cpp
> +++ lib/AsmParser/LLParser.cpp
> @@ -564,10 +564,7 @@
> NMD->addOperand(N);
> } while (EatIfPresent(lltok::comma));
>
> - if (ParseToken(lltok::rbrace, "expected end of metadata node"))
> - return true;
> -
> - return false;
> + return ParseToken(lltok::rbrace, "expected end of metadata node");
> }
>
> /// ParseStandaloneMetadata:
>
> EMAIL PREFERENCES
> http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list