[PATCH] [llvm-readobj] Properly decode DF_1_XXX flags

Davide Italiano dccitaliano at gmail.com
Sat May 23 17:13:09 PDT 2015


In http://reviews.llvm.org/D9958#177459, @echristo wrote:

> You can also just check in a pre-built one if that makes it easier...
>
> -eric


Hi,
it doesn't seem to make a lot of difference here. My preference is for not checking in binaries when possible, but if you think it makes more sense, I'll change the test. The only "problem" I may see here is that this test passes flag to the linker via -Wl, but it seems every reasonably modern linker supports this (and the flags).


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9958

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list