[PATCH] [PATCH] Stop resetting NoFramePointerElim in TargetMachine::resetTargetOptions

[Eric Christopher]

I like this much more, thank you.

A few inline comments, but don't bother with resubmitting after fixing them or responding, anything else can be follow up.

Thanks a lot!

-eric


================
Comment at: include/llvm/CodeGen/CommandFlags.h:233
@@ -232,2 +232,3 @@
   Options.NoFramePointerElim = DisableFPElim;
+  Options.NoFramePointerElimOverride = DisableFPElim.getNumOccurrences() > 0;
   Options.AllowFPOpFusion = FuseFPOps;
----------------
Should be possible to get rid of this now and just check the command line option?

================
Comment at: lib/ExecutionEngine/ExecutionEngineBindings.cpp:185
@@ -182,1 +184,3 @@
+  if (Mod)
+    setFunctionAttributes("", "", targetOptions, *Mod, true);
 
----------------
Comment the true argument, (and probably why we're not setting the first two arguments as well).

================
Comment at: test/CodeGen/X86/2014-08-29-CompactUnwind.ll:1
@@ -1,2 +1,2 @@
-; RUN: llc < %s -disable-fp-elim -mtriple x86_64-apple-darwin11 -mcpu corei7 -filetype=obj -o - | llvm-objdump -d -unwind-info -s - | FileCheck %s
+; RUN: llc < %s -mtriple x86_64-apple-darwin11 -mcpu corei7 -filetype=obj -o - | llvm-objdump -d -unwind-info -s - | FileCheck %s
 ; Regression test for http://llvm.org/bugs/show_bug.cgi?id=20800.
----------------
Should probably make this commit separately?

================
Comment at: tools/llc/llc.cpp:308
@@ -307,3 +307,3 @@
   // Override function attributes.
-  overrideFunctionAttributes(CPUStr, FeaturesStr, *M);
+  setFunctionAttributes(CPUStr, FeaturesStr, Options, *M, false);
 
----------------
Comment the false argument.

================
Comment at: tools/opt/opt.cpp:400
@@ -397,3 +399,3 @@
   // Override function attributes.
-  overrideFunctionAttributes(CPUStr, FeaturesStr, *M);
+  setFunctionAttributes(CPUStr, FeaturesStr, Options, *M, false);
 
----------------
Comment the false argument.

http://reviews.llvm.org/D9830

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/