[PATCH] [llgo] cmd/llgoi: use line editor

Peter Collingbourne peter at pcc.me.uk
Fri May 22 11:59:05 PDT 2015


Please add liner to the list of third-party packages in LICENSE.TXT. Other than that, LGTM.


================
Comment at: update_third_party.sh:104
@@ -91,1 +103,3 @@
+(cd $linerdir && git checkout $linerrev)
+
 # --------------------- license check ---------------------
----------------
Wouldn't this leave a .git directory in third_party/liner?

http://reviews.llvm.org/D9811

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list