[PATCH] [mips] Make TTypeEncoding indirect to allow .eh_frame to be read-only.
Daniel Sanders
daniel.sanders at imgtec.com
Fri May 22 03:44:31 PDT 2015
Handle N32/N64 differences properly by allowing MipsTargetObjectFile to
change the TType encoding. This allows us to have a reasonable default
when there's no TargetMachine available and do the right thing when it
is available. The exception tables are self-describing so there's no
risk of issues with mixing different encodings in the same binary.
In the long term, MCObjectFileInfo should probably have visibility of the
TargetMachine. Unfortunately there are a few issues with this:
- Not all callers that construct MCObjectFileInfo subclasses have a TargetMachine.
- Of those that have a TargetMachine, not all fully initialize it. In particular TargetOptions/MCTargetOptions are sometimes uninitialized.
- Of those that don't have a TargetMachine, not all have an ABI name stored elsewhere.
http://reviews.llvm.org/D9669
Files:
include/llvm/MC/MCObjectFileInfo.h
lib/MC/MCObjectFileInfo.cpp
lib/Target/Mips/MipsTargetObjectFile.cpp
lib/Target/Mips/MipsTargetObjectFile.h
test/CodeGen/Mips/ehframe-indirect.ll
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9669.26315.patch
Type: text/x-patch
Size: 6254 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150522/428119be/attachment.bin>
More information about the llvm-commits
mailing list