[llvm] r237976 - unique_ptrify LoadedObjectInfo::clone

Tobias Grosser tobias at grosser.es
Thu May 21 23:15:11 PDT 2015


On 05/22/2015 02:05 AM, David Blaikie wrote:
> Author: dblaikie
> Date: Thu May 21 19:05:05 2015
> New Revision: 237976
>
> URL: http://llvm.org/viewvc/llvm-project?rev=237976&view=rev
> Log:
> unique_ptrify LoadedObjectInfo::clone
>
> As noted in the original review, this is unused in tree & is used by
> Julia... that's problematic. This API coudl easily be deleted/modified
> by accident without any validation that it remains correct.

This seems to have broken gcc 4.7 buildbots. I reverted this (and 
r237975) for now until a fix can be found.

See for example:

http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/22162/steps/compile/logs/stdio

In file included from 
/home/buildslave/osuosl_slave/clang-x86_64-ubuntu-gdb-75/llvm.src/include/llvm/ExecutionEngine/JITEventListener.h:18:0,
                  from 
/home/buildslave/osuosl_slave/clang-x86_64-ubuntu-gdb-75/llvm.src/lib/ExecutionEngine/GDBRegistrationListener.cpp:11:
/home/buildslave/osuosl_slave/clang-x86_64-ubuntu-gdb-75/llvm.src/include/llvm/ExecutionEngine/RuntimeDyld.h:65:13: 
error: looser throw specifier for ‘virtual 
llvm::RuntimeDyld::LoadedObjectInfo::~LoadedObjectInfo()’
In file included from 
/home/buildslave/osuosl_slave/clang-x86_64-ubuntu-gdb-75/llvm.src/include/llvm/ExecutionEngine/RuntimeDyld.h:20:0,
                  from 
/home/buildslave/osuosl_slave/clang-x86_64-ubuntu-gdb-75/llvm.src/include/llvm/ExecutionEngine/JITEventListener.h:18,
                  from 
/home/buildslave/osuosl_slave/clang-x86_64-ubuntu-gdb-75/llvm.src/lib/ExecutionEngine/GDBRegistrationListener.cpp:11:
/home/buildslave/osuosl_slave/clang-x86_64-ubuntu-gdb-75/llvm.src/include/llvm/DebugInfo/DIContext.h:144:11: 
error:   overriding ‘virtual llvm::LoadedObjectInfo::~LoadedObjectInfo() 
noexcept (true)’

Best,
Tobias




More information about the llvm-commits mailing list