Looks good to me assuming that you write the cost model tests, and that you write tests for the ISel changes. REPOSITORY rL LLVM http://reviews.llvm.org/D9923 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/