[PATCH] [ELF] Simplify dynamic table entry creation

Simon Atanasyan simon at atanasyan.com
Thu May 21 15:19:50 PDT 2015


LGTM


REPOSITORY
  rL LLVM

================
Comment at: lib/ReaderWriter/ELF/Mips/MipsDynamicTable.h:37
@@ -42,5 +36,3 @@
     // The base address of the segment.
-    dyn.d_un.d_ptr = 0;
-    dyn.d_tag = DT_MIPS_BASE_ADDRESS;
-    _dt_baseaddr = this->addEntry(dyn);
+    _dt_baseaddr = this->addEntry(DT_MIPS_BASE_ADDRESS, 0, false);
 
----------------
I think we can initialize d_val field here instead of d_ptr and remove the third argument from the addEntry routine.

http://reviews.llvm.org/D9921

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list