[PATCH] Make it easier to use DwarfContext with MCJIT
Keno Fischer
kfischer at college.harvard.edu
Thu May 21 13:15:18 PDT 2015
REPOSITORY
rL LLVM
================
Comment at: include/llvm/DebugInfo/DIContext.h:147
@@ +146,3 @@
+
+ /// \brief Obtain the Load Address of a section by Name
+ ///
----------------
echristo wrote:
> Sentences end with a period. Also we have \brief support turned on so you don't need to use \brief anymore. (And in the other places :)
Will fix.
================
Comment at: include/llvm/DebugInfo/DIContext.h:173
@@ +172,3 @@
+ /// The caller is responsible for deallocation once the copy is no longer required.
+ virtual LoadedObjectInfo *clone() const = 0;
+};
----------------
echristo wrote:
> clone is entirely unused.
It's supposed to be available for the client to be able to obtain a copy of the LoadedObjectInfo, since the one it gets from MCJIT is passed by reference. We could probably change that one to a shared_ptr, but I didn't want to put that API breakage into the same commit.
http://reviews.llvm.org/D6961
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list