[PATCH] [LoopVectorize]Teach Loop Vectorizer about interleaved memory access

Hao Liu Hao.Liu at arm.com
Wed May 20 18:13:47 PDT 2015


In http://reviews.llvm.org/D9368#175547, @rengolin wrote:

> In http://reviews.llvm.org/D9368#175501, @HaoLiu wrote:
>
> > Michael, I agree with you and I'll separate the patch when committing.
>
>
> Unless you can guarantee that trunk will work with just the first patch (ie. you have tested both equally), I don't think it's a good idea to split the patch. The analysis does nothing without the actual vectorisation, and vice versa.
>
> It's a big patch, yes, but also this is a big change. I don't see what splitting the patches would gain us.
>
> The patch now looks more like what we had planned in the beginning, so as long as all comments are addressed, and all tests pass, I'm happy.
>
> Thank you for the effort of bringing this up again.
>
> cheers,
> --renato


Renato, I also agree with you. I think to commit separately as two patches or commit as a whole patch are similar and have no big differences.

Thanks,
-Hao


http://reviews.llvm.org/D9368

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list