[PATCH] [DebugInfo][FastISel] Prevent using debug location from previous block for local values
Sergey Dmitrouk
sdmitrouk at accesssoftek.com
Wed May 20 14:20:31 PDT 2015
In http://reviews.llvm.org/D9887#175863, @probinson wrote:
> Does this handle the case where there is a call in the middle of the block? There is a special case for the local value map at that point, IIRC.
Didn't try that, will do. This will need to account for calls of `flushLocalValueMap`, I thought it's used differently. Current version uses `MBB->begin()` which and probably won't work as expected. Thanks.
In http://reviews.llvm.org/D9887#175863, @probinson wrote:
> What happens when FastISel decides it can't finish selection for the block, and bails out to regular ISel?
Regular ISel already produces correct locations (hence this change uses same test as regular ISel). Not sure if there are some complicated cases which will lead to wrong results.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D9887
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list