[LNT] r237748 - Make show all points the default, also remove show single point

[Chris Matthews]

Author: cmatthews
Date: Tue May 19 18:53:04 2015
New Revision: 237748

URL: http://llvm.org/viewvc/llvm-project?rev=237748&view=rev
Log:
Make show all points the default, also remove show single point

To really understand the data, it is important to actually see all the
points, not just the aggregate points. That is a better default.

Show single point was a strange option, and is a little misleading. I
don't think it is popular, so remove it.

Modified:
    lnt/trunk/lnt/server/ui/templates/v4_graph.html
    lnt/trunk/lnt/server/ui/views.py

Modified: lnt/trunk/lnt/server/ui/templates/v4_graph.html
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/templates/v4_graph.html?rev=237748&r1=237747&r2=237748&view=diff
==============================================================================
--- lnt/trunk/lnt/server/ui/templates/v4_graph.html (original)
+++ lnt/trunk/lnt/server/ui/templates/v4_graph.html Tue May 19 18:53:04 2015
@@ -250,14 +250,10 @@ function update_tooltip(event, pos, item
                      {{ 'checked' if options.show_failures else ""}}></td>
               </tr>
               <tr>
-                <td>Show Sample Points:</td>
-                <td><input type="checkbox" name="show_points" value="yes"
-                     {{ 'checked' if options.show_points else ""}}></td>
-              </tr>
               <tr>
-                <td>Show All Sample Points:</td>
-                <td><input type="checkbox" name="show_all_points" value="yes"
-                     {{ 'checked' if options.show_all_points else ""}}></td>
+                <td>Hide Sample Points:</td>
+                <td><input type="checkbox" name="hide_all_points" value="yes"
+                     {{ 'checked' if options.hide_all_points else ""}}></td>
               </tr>
               <tr>
                 <td>Normalize By Median:</td>

Modified: lnt/trunk/lnt/server/ui/views.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/views.py?rev=237748&r1=237747&r2=237748&view=diff
==============================================================================
--- lnt/trunk/lnt/server/ui/views.py (original)
+++ lnt/trunk/lnt/server/ui/views.py Tue May 19 18:53:04 2015
@@ -466,9 +466,8 @@ def v4_graph():
     show_lineplot = not options['hide_lineplot']
     options['show_mad'] = show_mad = bool(request.args.get('show_mad'))
     options['show_stddev'] = show_stddev = bool(request.args.get('show_stddev'))
-    options['show_points'] = show_points = bool(request.args.get('show_points'))
-    options['show_all_points'] = show_all_points = bool(
-        request.args.get('show_all_points'))
+    options['hide_all_points'] = hide_all_points = bool(
+        request.args.get('hide_all_points'))
     options['show_linear_regression'] = show_linear_regression = bool(
         request.args.get('show_linear_regression'))
     options['show_failures'] = show_failures = bool(
@@ -727,14 +726,12 @@ def v4_graph():
 
             # Add the individual points, if requested.
             # For each point add a text label for the mouse over.
-            if show_all_points:
+            if not hide_all_points:
                 for i,v in enumerate(values):
                     point_metadata = dict(metadata)
                     point_metadata["date"] = str(dates[i])
                     points_data.append((x, v, point_metadata))
-            elif show_points:
-                points_data.append((x, min_value, metadata))
-
+            
             # Add the standard deviation error bar, if requested.
             if show_stddev:
                 mean = stats.mean(values)