[PATCH] reenable gep merging in some constrainted cases

Wei Mi wmi at google.com
Tue May 19 15:10:30 PDT 2015


Hi Quentin,

Yes, it is a tuning of the heuristic from http://reviews.llvm.org/D8911.

Because the regression I saw here has much smaller negative impact
compared with the original negative impact of gep merging, is it
possible that we leave r235455 there while we discuss a better fix?
Because in this way we can check is there any other analysis affected
by disabling gep merging.

Thanks,
Wei.

On Tue, May 19, 2015 at 3:00 PM, Quentin Colombet <qcolombet at apple.com> wrote:
> Hi Wei,
>
> Correct me if I am wrong, but this is a tuning of the heuristic from http://reviews.llvm.org/D8911, right?
>
> Given that you actually see a regression now (and the fact that after discussing with Chandler, I am not convinced the initial change makes sense), I would suggest that you revert r235455 and that we start again the discussion on how to properly fix that.
>
> Thanks,
> -Quentin
>
>
> REPOSITORY
>   rL LLVM
>
> http://reviews.llvm.org/D9865
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>




More information about the llvm-commits mailing list