[llvm] r237678 - Avoid size_t -> unsigned conversion in MathExtras.h header. NFC.

Yaron Keren yaron.keren at gmail.com
Tue May 19 04:29:55 PDT 2015


This caused a minor compilation error with Visual C++ in
lib/IR/ConstantFold.cpp which I fixed in r237683.

Yaron


2015-05-19 13:35 GMT+03:00 Pawel Bylica <chfast at gmail.com>:

> Author: chfast
> Date: Tue May 19 05:35:32 2015
> New Revision: 237678
>
> URL: http://llvm.org/viewvc/llvm-project?rev=237678&view=rev
> Log:
> Avoid size_t -> unsigned conversion in MathExtras.h header. NFC.
>
> Modified:
>     llvm/trunk/include/llvm/Support/MathExtras.h
>
> Modified: llvm/trunk/include/llvm/Support/MathExtras.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/MathExtras.h?rev=237678&r1=237677&r2=237678&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/Support/MathExtras.h (original)
> +++ llvm/trunk/include/llvm/Support/MathExtras.h Tue May 19 05:35:32 2015
> @@ -465,26 +465,26 @@ inline double Log2(double Value) {
>  /// Log2_32 - This function returns the floor log base 2 of the specified
> value,
>  /// -1 if the value is zero. (32 bit edition.)
>  /// Ex. Log2_32(32) == 5, Log2_32(1) == 0, Log2_32(0) == -1, Log2_32(6)
> == 2
> -inline unsigned Log2_32(uint32_t Value) {
> +inline size_t Log2_32(uint32_t Value) {
>    return 31 - countLeadingZeros(Value);
>  }
>
>  /// Log2_64 - This function returns the floor log base 2 of the specified
> value,
>  /// -1 if the value is zero. (64 bit edition.)
> -inline unsigned Log2_64(uint64_t Value) {
> +inline size_t Log2_64(uint64_t Value) {
>    return 63 - countLeadingZeros(Value);
>  }
>
>  /// Log2_32_Ceil - This function returns the ceil log base 2 of the
> specified
>  /// value, 32 if the value is zero. (32 bit edition).
>  /// Ex. Log2_32_Ceil(32) == 5, Log2_32_Ceil(1) == 0, Log2_32_Ceil(6) == 3
> -inline unsigned Log2_32_Ceil(uint32_t Value) {
> +inline size_t Log2_32_Ceil(uint32_t Value) {
>    return 32 - countLeadingZeros(Value - 1);
>  }
>
>  /// Log2_64_Ceil - This function returns the ceil log base 2 of the
> specified
>  /// value, 64 if the value is zero. (64 bit edition.)
> -inline unsigned Log2_64_Ceil(uint64_t Value) {
> +inline size_t Log2_64_Ceil(uint64_t Value) {
>    return 64 - countLeadingZeros(Value - 1);
>  }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150519/34064989/attachment.html>


More information about the llvm-commits mailing list