[PATCH] [mips][FastISel] Implement intrinsics memset, memcopy & memmove.

Daniel Sanders daniel.sanders at imgtec.com
Tue May 19 04:01:22 PDT 2015


LGTM


================
Comment at: lib/Target/Mips/MipsFastISel.cpp:480
@@ +479,3 @@
+  if (const auto *I = dyn_cast<Instruction>(V)) {
+    if (I->getParent() == FuncInfo.MBB->getBasicBlock()) {
+      Opcode = I->getOpcode();
----------------
Nit: Could you add a comment about why we require the same BB?

http://reviews.llvm.org/D7158

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list