[PATCH] Fix icmp lowering
hfinkel at anl.gov
hfinkel at anl.gov
Mon May 18 12:52:30 PDT 2015
REPOSITORY
rL LLVM
================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:1727
@@ -1726,2 +1726,3 @@
NewC = NewC.lshr(ShiftBits);
- if (ShiftBits && isLegalICmpImmediate(NewC.getSExtValue())) {
+ if (ShiftBits && NewC.getMinSignedBits() <= 64 &&
+ isLegalICmpImmediate(NewC.getSExtValue())) {
----------------
Why 64? Shouldn't this depend on the size of the type?
================
Comment at: test/CodeGen/Generic/icmp-illegal.ll:4
@@ +3,3 @@
+
+; CHECK-LABEL: test_ult
+define i1 @test_ult(i256 %a) nounwind {
----------------
What is this test testing? Did these crash previously?
http://reviews.llvm.org/D9147
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list