[PATCH] [PATCH] Stop resetting NoFramePointerElim in TargetMachine::resetTargetOptions

Akira Hatanaka ahatanak at gmail.com
Mon May 18 11:44:33 PDT 2015


Hi echristo, dexonsmith,

This is part of the work to remove TargetMachine::resetTargetOptions.

In this patch, instead of updating global variable TargetOptions::NoFramePointerElim in resetTargetOptions, its use in DisableFramePointerElim is replaced with calls to TargetOptions::noFramePointerElim and TargetFrameLowering::noFramePointerElim. These functions determine on a per-function basis if frame pointer elimination should be disabled.

There is no change in functionality except that cl:opt option "disable-fp-elim" can now override function attribute "no-frame-pointer-elim". I removed the option from test case 2014-08-29-CompactUnwind.ll to prevent it from changing the output (it had no effect previously, but with this patch, it overrides the function attribute).

http://reviews.llvm.org/D9830

Files:
  include/llvm/CodeGen/CommandFlags.h
  include/llvm/Target/TargetFrameLowering.h
  include/llvm/Target/TargetOptions.h
  lib/CodeGen/TargetOptionsImpl.cpp
  lib/Target/ARM/ARMFastISel.cpp
  lib/Target/ARM/ARMFrameLowering.cpp
  lib/Target/ARM/ARMFrameLowering.h
  lib/Target/ARM/ARMSubtarget.cpp
  lib/Target/ARM/ARMSubtarget.h
  lib/Target/TargetMachine.cpp
  test/CodeGen/ARM/disable-fp-elim.ll
  test/CodeGen/X86/2014-08-29-CompactUnwind.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9830.25991.patch
Type: text/x-patch
Size: 11067 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150518/dc746893/attachment.bin>


More information about the llvm-commits mailing list