[PATCH] [LoopVectorize]Teach Loop Vectorizer about interleaved memory access
Adam Nemet
anemet at apple.com
Mon May 18 09:30:56 PDT 2015
================
Comment at: include/llvm/Analysis/LoopAccessAnalysis.h:670-671
@@ -488,1 +669,4 @@
+
+ /// Contains the relationships between the members and the interleaved access.
+ DenseMap<Instruction *, InterleaveGroup *> InterleaveGroupMap;
};
----------------
I've only started looking at this patch but I have a quick initial, more fundamental comment.
You are modifying an analysis pass (LoopAccessAnalysis). Please add support for printing the new information gathered by the analysis. Please also add tests under test/Analysis/LoopAccessAnalysis to verify the new information.
You may even want separate out the patch for the analysis part (LAA + tests) from the transformation parts (LV + tests + etc).
http://reviews.llvm.org/D9368
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list