[PATCH] [mips] The naming convention for private labels is ABI dependant.

Vasileios Kalintiris Vasileios.Kalintiris at imgtec.com
Mon May 18 07:14:04 PDT 2015


Won't we have to update the existing tests that depend on this behaviour?
I'm getting the following failures with llvm-lit:

Failing Tests (12):

  LLVM :: CodeGen/Mips/analyzebranch.ll
  LLVM :: CodeGen/Mips/atomic.ll
  LLVM :: CodeGen/Mips/blez_bgez.ll
  LLVM :: CodeGen/Mips/blockaddr.ll
  LLVM :: CodeGen/Mips/fpbr.ll
  LLVM :: CodeGen/Mips/llvm-ir/ashr.ll
  LLVM :: CodeGen/Mips/llvm-ir/indirectbr.ll
  LLVM :: CodeGen/Mips/llvm-ir/lshr.ll
  LLVM :: CodeGen/Mips/llvm-ir/select.ll
  LLVM :: CodeGen/Mips/llvm-ir/shl.ll
  LLVM :: CodeGen/Mips/longbranch.ll
  LLVM :: CodeGen/Mips/octeon.ll

Other than that it looks good to me. Please, update the existing revision if you'd like me to review the tests' changes too.


http://reviews.llvm.org/D9821

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list