[llvm] r237405 - Add a missing piece of existing practice to the developer policy. This may need further refinement, but I think is roughly correct.

Nick Lewycky nlewycky at google.com
Fri May 15 16:00:53 PDT 2015


On 14 May 2015 at 16:28, Eric Christopher <echristo at gmail.com> wrote:

> Mmm.. might want to point to the script for the git folk?
>

I would like that, but when working on the document it didn't feel like it
would "fit". It's really a policy document and seems to be trying to not
talk about such details. I don't know a better place to put it either.

-eric
>
> On Thu, May 14, 2015 at 4:27 PM Nick Lewycky <nicholas at mxc.ca> wrote:
>
>> Author: nicholas
>> Date: Thu May 14 18:21:33 2015
>> New Revision: 237405
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=237405&view=rev
>> Log:
>> Add a missing piece of existing practice to the developer policy. This
>> may need further refinement, but I think is roughly correct.
>>
>> Modified:
>>     llvm/trunk/docs/DeveloperPolicy.rst
>>
>> Modified: llvm/trunk/docs/DeveloperPolicy.rst
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/DeveloperPolicy.rst?rev=237405&r1=237404&r2=237405&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/docs/DeveloperPolicy.rst (original)
>> +++ llvm/trunk/docs/DeveloperPolicy.rst Thu May 14 18:21:33 2015
>> @@ -324,6 +324,11 @@ Below are some guidelines about the form
>>  * Text formatting and spelling should follow the same rules as
>> documentation
>>    and in-code comments, ex. capitalization, full stop, etc.
>>
>> +* If the commit is a bug fix on top of another recently committed patch,
>> or a
>> +revert or reapply of a patch, include the svn revision number of the
>> prior
>> +related commit. This could be as simple as "Revert rNNNN because it
>> caused
>> +PR#".
>> +
>>  For minor violations of these recommendations, the community normally
>> favors
>>  reminding the contributor of this policy over reverting. Minor
>> corrections and
>>  omissions can be handled by sending a reply to the commits mailing list.
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150515/ef80dadc/attachment.html>


More information about the llvm-commits mailing list