[PATCH] Move McInstrDesc methods which use MCInst to their own cpp file

Jim Grosbach grosbach at apple.com
Fri May 15 12:20:56 PDT 2015


Seems reasonable, especially since it’ll allow us to more effectively forward declare classes more.

Please add a file-level comment blurb for MCInstrDesc.cpp and run clang-format on the file, but otherwise LGTM.


> On May 13, 2015, at 3:54 PM, Pete Cooper <peter_cooper at apple.com> wrote:
> 
> Hi Jim
> 
> This will become useful in a later commit to reduce the includes in MC headers.  MCInstrDesc.h currently includes MCInst.h (then transitively most of the MC headers) because of 2 methods.  This patch moves these out to their own cpp file.
> 
> Thanks,
> Pete
> 
> <MCInstrDesc.diff>





More information about the llvm-commits mailing list