[PATCH] Ensure FDE reads the correct CIE when relocating the LSDA.

Lang Hames lhames at gmail.com
Fri May 15 10:33:47 PDT 2015


In http://reviews.llvm.org/D9783#173222, @kledzik wrote:

> I like to have lots of little test cases that are pruned down to just test a specific area.  In this case, there should be a separate test for _eh_frame section with multiple CIEs.  In the test case, you don't need the __compact_unwind section. You don't need code or relocations on the code.


I've removed the __compact_unwind section and the relocations.

I agree that test cases should be small and orthogonal, but in this case the test for FDE relocations involving multiple CIEs will necessarily test everything that the single CIE test will - is it worth having the later as a separate test at that point?


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9783

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list