[polly] r237431 - Give each memory access a reference ID

Tobias Grosser tobias at grosser.es
Fri May 15 05:28:06 PDT 2015


On 05/15/2015 12:59 PM, Johannes Doerfert wrote:
> Hey Tobias,
>
> some thoughts on this patch but nothing important.

Thanks for the comments.

> On 05/15, Tobias Grosser wrote:
>> Author: grosser
>> Date: Fri May 15 04:58:32 2015
>> New Revision: 237431
>>
>> +  std::string IdName;
>> +  raw_string_ostream IdNameStream(IdName);
>> +  IdNameStream << "__polly_array_ref_ " << Identifier;
>> +  IdNameStream.flush();
> This seems overly complicated, what about:
>    ("XXXX" + std::to_str(Identifier)).c_str();

237440

>> +  this->Id = isl_id_alloc(Ctx, IdName.c_str(), nullptr);
>
>> +  int Identifier = 0;
>> +
>> -    MemAccs.push_back(new MemoryAccess(Access, AccessInst, this, SAI));
>> +    MemAccs.push_back(
>> +        new MemoryAccess(Access, AccessInst, this, SAI, Identifier));
>> +    Identifier++;
> MemAccs.size() would do the trick to I guess.

237441

Tobias



More information about the llvm-commits mailing list