[PATCH] Add archive step to lldb mac builder, combine first build and retry step

Vince Harron vince at nethacker.com
Thu May 14 14:27:20 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:526
@@ -526,1 +525,3 @@
+    f = archiveLLDBTestTraces(f,
+                              "build/lldb-test-traces-*")
     return f
----------------
Please add a comment, something like

# this glob will include trace results for all compilers/archs
# one example: build/lldb-test-trace-x86_64-clang


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:536
@@ -534,2 +535,3 @@
                            haltOnFailure=False,
-                           workdir='%s' % llvm_builddir))
+                           flunkOnFailure=False,
+                           workdir='.'))
----------------
I think we should flunk if the zip fails.  What do you think?

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:766
@@ -766,2 +765,3 @@
                   workdir=lldb_srcdir))
-
+    DOTEST_OPTS = ' '.join(['-m',
+                            '--executable',
----------------
You should probably keep all python variable names lower case.

http://reviews.llvm.org/D9731

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list