[PATCH] Add archive step to lldb mac builder, combine first build and retry step
Siva Chandra
sivachandra at google.com
Thu May 14 14:13:06 PDT 2015
LGTM with nits. Also, I am assuming it was tested.
================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:526
@@ -526,1 +525,3 @@
+ f = archiveLLDBTestTraces(f,
+ "build/lldb-test-traces-*")
return f
----------------
Lines 525 and 526 can be on the same line.
================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:531
@@ -531,1 +530,3 @@
+def archiveLLDBTestTraces(f,
+ test_trace):
f.addStep(ShellCommand(name="compress test traces",
----------------
Lines 530 and 531 can be on the same line.
================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:782
@@ -775,1 +781,3 @@
+ f = archiveLLDBTestTraces(f,
+ "lldb.src/DerivedData/lldb-test-results")
----------------
Line 781 and 782 can be on one line.
http://reviews.llvm.org/D9731
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list