[PATCH] Add another InstCombine pass after LoopUnroll

Quentin Colombet qcolombet at apple.com
Thu May 14 13:45:14 PDT 2015


Hi Wei,

LGTM with some fixes on the test case.

Thanks,
-Quentin


REPOSITORY
  rL LLVM

================
Comment at: test/Transforms/LoopUnroll/unroll-cleanup.ll:24
@@ +23,3 @@
+entry:
+  %0 = load i32, i32* @b, align 4
+  %tobool20 = icmp eq i32 %0, 0
----------------
Please run “opt -instnamer” on the input test to get rid of %[0-9]+ names. Those are a pain in the neck when we want to update the test.

================
Comment at: test/Transforms/LoopUnroll/unroll-cleanup.ll:83
@@ +82,2 @@
+
+attributes #0 = { nounwind uwtable "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+sse,+sse2" "unsafe-fp-math"="false" "use-soft-float"="false" }
----------------
Do you really need all those attributes to expose the problem?

http://reviews.llvm.org/D9777

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list