[llvm-lit] remove %t files before running a test

[Tzafrir Poupko]

Hi James,

There are 2 reasons for the -f

1. This is what is done currently by more then 300 tests and I wouldn't
like to change this.
2. Using -f suppresses error messages that will happen when no temporary
file exists

Since there is no standard function in python to delete files and
directories matching a pattern
I thought using rm -rf would be a better solution then implementing my own.

Tzafrir

On Thu, May 14, 2015 at 3:27 PM, James Molloy <james at jamesmolloy.co.uk>
wrote:

> Hi Tzafrir,
>
> This sounds like a good idea to me.
>
> +    subprocess.call(['rm','-rf',path+"*"])
>
>
>
> This is super dangerous. Why the -f ?
>
> Cheers,
>
> James
>
> On Thu, 14 May 2015 at 13:22 Tzafrir Poupko <tzafrir11 at gmail.com> wrote:
>
>> Before running a test, purge all %t files used by previous tests.
>> Remove any custom file used in test which was prefixed by %t.
>> There are over 300 clang tests that run "rm -rf %t" as first run command,
>> this patch will make it automaticlly.
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150514/d5d020d6/attachment.html>