[PATCH] [ValueTracking] refactor: extract method noCommonSetBits
David Majnemer
david.majnemer at gmail.com
Thu May 14 00:00:00 PDT 2015
Looks pretty straightforward, LGTM.
================
Comment at: include/llvm/Analysis/ValueTracking.h:51
@@ +50,3 @@
+ /// Returns true if LHS and RHS have no set bits in common.
+ bool noCommonSetBits(Value *LHS, Value *RHS, const DataLayout &DL,
+ AssumptionCache *AC = nullptr,
----------------
`hasNoCommonsBitsSet` sounds a little more natural to me.
http://reviews.llvm.org/D9734
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list