[llvm] r237157 - YAML: Fix typos. NFC.

Sean Silva chisophugis at gmail.com
Wed May 13 16:23:39 PDT 2015


On Tue, May 12, 2015 at 10:40 AM, Alex L <arphaman at gmail.com> wrote:

> Oh, I didn't know that this shorthand existed. I will revert this commit
> then.
>

You aren't the first to make this mistake. See r164767.

-- Sean Silva


>
> Thanks,
> Alex
>
> 2015-05-12 10:38 GMT-07:00 Benjamin Kramer <benny.kra at gmail.com>:
>
>
>> > On 12.05.2015, at 19:31, Alex Lorenz <arphaman at gmail.com> wrote:
>> >
>> > Author: arphaman
>> > Date: Tue May 12 12:31:17 2015
>> > New Revision: 237157
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=237157&view=rev
>> > Log:
>> > YAML: Fix typos. NFC.
>>
>> 'iff' is shorthand for 'if and only if', not a typo.
>>
>> - Ben
>>
>> > Modified:
>> >    llvm/trunk/lib/Support/YAMLTraits.cpp
>> >
>> > Modified: llvm/trunk/lib/Support/YAMLTraits.cpp
>> > URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/YAMLTraits.cpp?rev=237157&r1=237156&r2=237157&view=diff
>> >
>> ==============================================================================
>> > --- llvm/trunk/lib/Support/YAMLTraits.cpp (original)
>> > +++ llvm/trunk/lib/Support/YAMLTraits.cpp Tue May 12 12:31:17 2015
>> > @@ -75,7 +75,7 @@ bool Input::setCurrentDocument() {
>> >   if (DocIterator != Strm->end()) {
>> >     Node *N = DocIterator->getRoot();
>> >     if (!N) {
>> > -      assert(Strm->failed() && "Root is NULL iff parsing failed");
>> > +      assert(Strm->failed() && "Root is NULL if parsing failed");
>> >       EC = make_error_code(errc::invalid_argument);
>> >       return false;
>> >     }
>> > @@ -102,7 +102,7 @@ bool Input::mapTag(StringRef Tag, bool D
>> >     // If no tag found and 'Tag' is the default, say it was found.
>> >     return Default;
>> >   }
>> > -  // Return true iff found tag matches supplied tag.
>> > +  // Return true if found tag matches supplied tag.
>> >   return Tag.equals(foundTag);
>> > }
>> >
>> >
>> >
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150513/4bfb0783/attachment.html>


More information about the llvm-commits mailing list