[PATCH] [X86] Fix PR23271 - RIP-relative decoding bug in disassembler.

Chandler Carruth chandlerc at gmail.com
Wed May 13 14:48:53 PDT 2015


Looks good with the test case changed as below.


================
Comment at: test/MC/Disassembler/X86/x86-64.txt:327
@@ +326,3 @@
+# *not* in general.
+# XFAIL: vaddps	(%r10,%r9), %zmm20, %zmm15
+0x62 0x11 0x5c 0x40 0x58 0x3c 0x0a
----------------
XFAIL doesn't work this way...

You only write one XFAIL per test file, and it fails the entire file.

I think you want to write the CHECKs as they are today, and as FIXME:s for what they should be.

http://reviews.llvm.org/D9110

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list