[PATCH] Stop resetting SanitizeAddress in TargetMachine::resetTargetOptions

Eric Christopher echristo at gmail.com
Wed May 13 14:00:40 PDT 2015


That's not quite what I meant. I meant just have the places that need to
know whether or not we're sanitizing look at the function attribute rather
than resetting a value on MCOptions.

Thanks!

-eric

On Fri, May 8, 2015 at 4:16 PM Akira Hatanaka <ahatanak at gmail.com> wrote:

> In http://reviews.llvm.org/D9570#169482, @echristo wrote:
>
> > Hi Akira,
> >
> > This is just moving the resetting to a different place. How about we get
> >  rid of the resetting completely?
>
>
> Hi Eric,
>
> Wouldn't getting rid of the resetting completely make it impossible to
> turn instrumentation on and off on a per-function basis? I don't know how
> important it is to have that capability, but it looks like r206971 was
> committed to enable it.
>
>
> http://reviews.llvm.org/D9570
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150513/793d2dab/attachment.html>


More information about the llvm-commits mailing list