[PATCH] [PlaceSafepoints] New attributes for patchable statepoints.

Sanjoy Das sanjoy at playingwithpointers.com
Wed May 13 12:41:54 PDT 2015


================
Comment at: lib/Transforms/Scalar/PlaceSafepoints.cpp:908-911
@@ +907,6 @@
+  AttributeSet AS = CS.getAttributes();
+  Attribute AttrID =
+      AS.getAttribute(AttributeSet::FunctionIndex, "statepoint-id");
+  Attribute AttrNumPatchBytes = AS.getAttribute(AttributeSet::FunctionIndex,
+                                                "statepoint-num-patch-bytes");
+
----------------
pgavlin wrote:
> Are these attributes propagated by PlaceSafepoints? If so, should they be dropped instead? I don't necessarily see any reason to drop them; just wondering if this was considered.
I think dropping them is a good idea, if nothing else, it makes the intent more obvious.

http://reviews.llvm.org/D9735

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list