[PATCH] Indirect call target profiling compiler-rt changes

[Xinliang David Li]

What I meant in the review is that the source comment above this
change also needs to be updated to match.

On Wed, May 13, 2015 at 11:08 AM, Betul Buyukkurt <betulb at codeaurora.org> wrote:
> Instrumentation based profile readers depend on the magic field check to decide which reader class to instantiate.

How about FormatVersion? What is the convention here (using
FormatVersion vs Magic string)?

> To allow the reading of the new profile data output (extended w/ value profile entries) with a different reader class, the magic field has been updated from lprof(r/R) to vprof(r/R).

I suppose this is related to your new profiler reader patch.    What
do you mean by allowing reading of extended value profile data with a
different reader class?  A different reader class means the old reader
?

David

>
>
> http://reviews.llvm.org/D9009
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>