[PATCH] [AArch64] Codegen VMAX/VMIN for safe math cases

Renato Golin renato.golin at linaro.org
Wed May 13 04:49:48 PDT 2015


On 13 May 2015 at 11:49, Artyom Skrobov <artyom.skrobov at arm.com> wrote:
> What do you think of a refactoring like this (instead of the switch and the subsequent code), to take the common code out of the two cases?

This looks better, yes.


> The same refactoring may be performed in ARMTargetLowering::PerformSELECT_CCCombine, too.

I'd leave this as it is. With James' patch, this could probably change
again. If it doesn't, feel free to propose that patch again when you
guys are done with the other changes.

cheers,
--renato



More information about the llvm-commits mailing list