[PATCH] [lld] [PATCH] Properly handle relocation for LSDA in MachO eh-frames.

[Lang Hames]

Committed in r237222. Thanks for the review Rui.


REPOSITORY
  rL LLVM

================
Comment at: lib/ReaderWriter/MachO/MachONormalizedFileToAtoms.cpp:677
@@ +676,3 @@
+    } else
+      ++idx;
+  }
----------------
ruiu wrote:
> You could write like this.
> 
>   if (argStr[idx] == 'L')
>     adi._maybeHaveLSDA = true;
>   ++idx;
> 
Agreed, however this style anticipates parsing of multi-character fields (e.g. "eh"), where the length isn't the same for all fields. I expect that I'll hit test cases where this extension is needed soon enough.

http://reviews.llvm.org/D9723

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/