[PATCH] llvm.noalias - don't interfere with llvm.assume

Philip Reames listmail at philipreames.com
Tue May 12 10:53:06 PDT 2015


LGTM.  Two entirely optional comments, no further review needed.


================
Comment at: lib/Analysis/ValueTracking.cpp:393
@@ -392,3 +392,3 @@
 // Is this an intrinsic that cannot be speculated but also cannot trap?
 static bool isAssumeLikeIntrinsic(const Instruction *I) {
   if (const CallInst *CI = dyn_cast<CallInst>(I))
----------------
If you're touching this code anyways, please update the name to something more clear?

================
Comment at: lib/Analysis/ValueTracking.cpp:398
@@ -397,3 +397,3 @@
       default: break;
       // FIXME: This list is repeated from NoTTI::getIntrinsicCost.
       case Intrinsic::assume:
----------------
Is it time to common these two lists?

http://reviews.llvm.org/D9379

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list