[PATCH] Split the calling convention and statepoint flags operand to STATEPOINT into two separate operands.

Philip Reames listmail at philipreames.com
Tue May 12 10:31:40 PDT 2015


LGTM.  One optional comment, no further review needed.

Thanks.


================
Comment at: docs/Statepoints.rst:486
@@ -485,1 +485,3 @@
 
+* Constant which describes the calling convention of the call target
+* Constant which describes the flags passed to the statepoint intrinsic
----------------
Can you add something to the effect of: This constant is a valid calling convention identifier (http://llvm.org/docs/LangRef.html#calling-conventions) for the version of LLVM used to generate the stackmap.  There are no additional compatibility guarantees made for this field over what LLVM provides elsewhere w.r.t. these indentifiers.

http://reviews.llvm.org/D9623

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list