[PATCH] [RewriteStatepointsForGC] Extend base pointer to handle more cases w/vectors
Philip Reames
listmail at philipreames.com
Tue May 12 10:15:52 PDT 2015
================
Comment at: lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:304
@@ +303,3 @@
+ if (isa<ConstantInt>(Index) && isa<ConstantInt>(InsertIndex) &&
+ Index != InsertIndex)
+ return findBaseOfVector(IEI->getOperand(0), Index);
----------------
pgavlin wrote:
> Isn't `Index != InsertIndex` redundant?
Technically, yes, but I think the code would be far less obvious without it. I'd prefer to leave it. Do you object?
http://reviews.llvm.org/D9676
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list