[PATCH] [mips][FastISel] Simplify callabi.ll by using multiple check prefixes.

Daniel Sanders daniel.sanders at imgtec.com
Tue May 12 03:37:28 PDT 2015


LGTM with a couple nits


================
Comment at: test/CodeGen/Mips/Fast-ISel/callabi.ll:11
@@ -19,1 +10,3 @@
+define void @cxi() {
+; ALL-LABEL:    cxi:
 
----------------
Nit: Indentation
Likewise for the other ALL-LABEL's

================
Comment at: test/CodeGen/Mips/Fast-ISel/callabi.ll:356-363
@@ -434,10 +355,9 @@
 
-declare void @xifii(i32, float, i32, i32) #1
-
-; FIXME: this function will not pass yet. 
-; Function Attrs: nounwind
-; define void @cxfid() #0 {
-;entry:
-;  call void @xfid(float 0x4013B851E0000000, i32 811123, double 0x40934BFF487FCB92)
+; FIXME: this function will not pass yet.
+;declare void @xfid(float, i32, double) #1
+;
+;define void @cxfid() {
+;  call void @xfid(float 0x4013B851E0000000, i32 811123,
+;                  double 0x40934BFF487FCB92)
 ;  ret void
 ;}
----------------
I know this isn't from your patch but: Please delete this and add it when it passes.

http://reviews.llvm.org/D9635

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list