[PATCH] Implement `internal_start/join_thread` on Mac OS X

Alexander Potapenko glider at google.com
Tue May 12 02:40:10 PDT 2015


================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:340
@@ +339,3 @@
+void *internal_start_thread(void(*func)(void *arg), void *arg) {
+#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 80000
+  // Start the thread with signals blocked, otherwise it can steal user signals.
----------------
Why is this disabled on certain iOS versions?
Do we really need TSan on iOS? (note that the shadow memory overhead is quite big and the 32-bit address space may be too little).

http://reviews.llvm.org/D9638

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list