[PATCH] Add per-test timeouts to lit

Daniel Dunbar daniel at zuster.org
Mon May 11 21:33:53 PDT 2015


Hi Jonathan,

The race I was talking about in watch() is this:
--
1. Client opens Watchdog(...)
2. Watchdog.handler() fires, does nothing because self.popens is empty.
3. Client calls Watchdog.watch()
4. Now that process will never be killed by the timeout.
--

For the second comment, you can't just set a param to change
execute_external, you need to change it in the test suites lit.cfg file. If
you can't reproduce with that I am not sure...

 - Daniel

On Mon, May 11, 2015 at 5:24 PM, Jonathan Roelofs <jonathan at codesourcery.com
> wrote:

> ping: @ddunbar, can you clarify your review comments please?
>
>
> http://reviews.llvm.org/D6584
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150511/dece980d/attachment.html>


More information about the llvm-commits mailing list