[PATCH] ARM: No need for 8 byte alignment of LDRD on newer CPUs

Tim Northover t.p.northover at gmail.com
Mon May 11 18:03:18 PDT 2015


Does the patch actually affect the given test-case? I would have expected thumbv7-apple-darwin to have ABIAlignment of 4 anyway.


================
Comment at: test/CodeGen/Thumb2/thumb2-ldrd.ll:5
@@ -4,4 +4,3 @@
 
-define i64 @t(i64 %a) nounwind readonly {
-entry:
+; CHECK-LABEL: foo
 ; CHECK: ldrd
----------------
Is "foo" really any better than "t"? I say either go for a proper rename that gives some hint of what's being tested or leave it as-is.

The best way to check for a function start is "CHECK-LABEL: my_function:" (note the colon at the end).

http://reviews.llvm.org/D9686

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list