[PATCH] Split the calling convention and statepoint flags operand to STATEPOINT into two separate operands.

[Philip Reames]

Minor comments below.  Looks close to ready.

I'm mildly disturbed you didn't need to change anything else in the backend.  Did you audit things like X86MCInstLowering and X86ISelLowering to make sure they weren't using raw indices into the operand list?


================
Comment at: include/llvm/CodeGen/StackMaps.h:100
@@ -98,1 +99,3 @@
 
+  enum {
+    CCOffset = 1,
----------------
Why two enums?  I suspect there's a semantic difference, possibly a name or comment is appropriate?

================
Comment at: test/CodeGen/X86/statepoint-allocas.ll:75
@@ -74,2 +74,3 @@
 ; CHECK: .short	0
-; CHECK: .short	3
+; CHECK: .short	4
+; SmallConstant (0)
----------------
With this change, you're changing the public format.  Thus, we need to update: http://llvm.org/docs/Statepoints.html#stack-map-format

Having said that, it looks like the documentation never included the flags at all.  Oops.  Can you add entries for both calling convention and flags?

http://reviews.llvm.org/D9623

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/