[PATCH] [DebugInfo] Add debug locations to constant SD nodes continued

[David Blaikie]

main code change looks reasonable with one minor change suggested

Do you have any stats on debug info size growth? A per-section breakdown/increase comparison of a clang bootstrap with -gmlt would be really handy.


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:987
@@ +986,3 @@
+    case ISD::ConstantFP:
+      assert(false && "Querying for Constant and ConstantFP nodes requires "
+                      "debug location.  Use another overload.");
----------------
use llvm_unreachable rather than assert(false)

(alternatively, assert(N->getOpcode() != ISD::Constant && N->getOpcode() != ISD::ConstantFP && "..."))

http://reviews.llvm.org/D9604

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/