[PATCH] [RewriteStatepointsForGC] Extend base pointer to handle more cases w/vectors

Philip Reames listmail at philipreames.com
Mon May 11 13:15:05 PDT 2015


Hi sanjoy, AndyAyers, igor-laevsky, pgavlin,

When relocating a pointer, we need to determine a base pointer for the derived pointer being relocated.  We have limited support for handling a pointer extracted from a vector; the current code only handled the case where the entire vector was known to contain base pointers.  This patch extends the reasoning to handle chains of insertelements where the indices are constants.  This case turns out to be fairly common in vectorized code.  We can now handle vectors which contains mixtures of base and derived pointers provided the insertelements use constant indices.  

Note that this doesn't solve the general problem.  To handle variable indexed insertelements, we'd need to scalarize and introduce conditional branching based on the index.  Alternatively, we could eagerly scalarize, but the code structure doesn't currently make either fix easy.  The patch also doesn't handle shufflevector or other vector manipulation for much the same reasons.   I plan to defer this work until I have a motivating test case.

http://reviews.llvm.org/D9676

Files:
  lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
  test/Transforms/RewriteStatepointsForGC/live-vector.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9676.25499.patch
Type: text/x-patch
Size: 4782 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150511/2aa99019/attachment.bin>


More information about the llvm-commits mailing list