[PATCH] [DWARF] Add CIE header fields address_size and segment_size when generating dwarf-4

Paul Robinson Paul_Robinson at playstation.sony.com
Mon May 11 13:03:30 PDT 2015


Granted DWARF calls the field "segment_size" but actually it's a segment _selector_ size.  (Maybe we should fix that name for DWARF 5...)


================
Comment at: lib/MC/MCDwarf.cpp:1310
@@ +1309,3 @@
+    // Segment Size
+    streamer.EmitIntValue(0, 1);
+  }
----------------
LLVM doesn't support any targets with segmented addresses?


================
Comment at: test/MC/ARM/dwarf-cfi-initial-state.s:17
@@ -16,1 +16,3 @@
+# CHECK: DW_CFA_nop:
+# CHECK: DW_CFA_nop:
 # CHECK-NOT: DW_CFA
----------------
It's not clear to me where these extra nops came from.

http://reviews.llvm.org/D9558

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list