[PATCH] [llvm-mc] fix 64-bit mode call disassembly to ignore opcode size prefix

Matthew Barney m4b.github.io at gmail.com
Mon May 11 11:41:52 PDT 2015


FYI, I don't have write privileges, so I assume someone else needs to run arc land if this is ready to be committed and pushed?

Similarly for diff http://reviews.llvm.org/D9514


================
Comment at: lib/Target/X86/Disassembler/X86DisassemblerDecoder.cpp:994
@@ +993,3 @@
+    case 0xE9:
+      attrMask ^= ATTR_OPSIZE;
+      insn->immediateSize = 4;
----------------
craig.topper wrote:
> Why no opcodeType check here? Can't this alias?
Nice catch!  The instructions they would have messed up, like psubsb/vpsubsb, don't have any unit tests, so it wasn't showing up in testing.  I'll check for a ONEBYTE opcodeType here, add the unit tests, and fix the identation problems in the next diff.

http://reviews.llvm.org/D9573

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list