[llvm] r236416 - AVX-512: enabled tests for AVX512F set

[Demikhovsky, Elena]

I'll take a look during this week.

-  Elena


-----Original Message-----
From: Adam Nemet [mailto:anemet at apple.com] 
Sent: Monday, May 11, 2015 15:06
To: Demikhovsky, Elena
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm] r236416 - AVX-512: enabled tests for AVX512F set


> On May 11, 2015, at 1:42 PM, Adam Nemet <anemet at apple.com> wrote:
> 
> 
>> On May 11, 2015, at 1:02 PM, Demikhovsky, Elena <elena.demikhovsky at intel.com> wrote:
>> 
>> I want to be sure that this test passes. We plan to cover all instructions and combinations.
>> If it is important, I can move error checks to another file.
> 
> We generally don’t remove tests unless the test is broken or we’re replacing it with something better, especially not silently like this.   Please find a way to restore the coverage for this.

I am also not sure I understand why you think we can’t have tests for diagnostics intermixed with normal tests.  I think I copied this approach from some existing tests.  Please explain.

Thanks,
Adam

> 
> Adam
> 
>> 
>> -  Elena
>> 
>> 
>> -----Original Message-----
>> From: Adam Nemet [mailto:anemet at apple.com]
>> Sent: Monday, May 11, 2015 12:26
>> To: Demikhovsky, Elena
>> Cc: llvm-commits at cs.uiuc.edu
>> Subject: Re: [llvm] r236416 - AVX-512: enabled tests for AVX512F set
>> 
>> 
>>> On May 4, 2015, at 1:09 PM, Elena Demikhovsky <elena.demikhovsky at intel.com> wrote:
>>> 
>>> Author: delena
>>> Date: Mon May  4 06:09:41 2015
>>> New Revision: 236416
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=236416&view=rev
>>> Log:
>>> AVX-512: enabled tests for AVX512F set
>>> 
>>> Modified:
>>>  llvm/trunk/test/MC/X86/avx512-encodings.s
>>>  llvm/trunk/test/MC/X86/x86-64-avx512dq.s
>>> 
>>> Modified: llvm/trunk/test/MC/X86/avx512-encodings.s
>>> URL: 
>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/X86/avx512-en
>>> co dings.s?rev=236416&r1=236415&r2=236416&view=diff
>>> ====================================================================
>>> ==
>>> ========
>>> --- llvm/trunk/test/MC/X86/avx512-encodings.s (original)
>>> +++ llvm/trunk/test/MC/X86/avx512-encodings.s Mon May  4 06:09:41 
>>> +++ 2015
>>> @@ -1,5 +1,4 @@
>>> -// RUN: not llvm-mc -triple x86_64-unknown-unknown -mcpu=knl 
>>> -mattr=+avx512dq --show-encoding %s 2> %t.err | FileCheck %s -// RUN:
>>> FileCheck --check-prefix=ERR < %t.err %s
>>> +// RUN: llvm-mc -triple x86_64-unknown-unknown -mcpu=knl 
>>> +-mattr=+avx512dq --show-encoding < %s  | FileCheck %s
>>> 
>>> // CHECK: vaddpd %zmm6, %zmm27, %zmm8 // CHECK:  encoding: 
>>> [0x62,0x71,0xa5,0x40,0x58,0xc6] @@ -5809,14
>>> +5808,6 @@ vinserti32x4  $1, %xmm21, %zmm5, %zmm17 // CHECK: encoding: 
>>> [0x62,0xe3,0x1d,0x40,0x38,0x4f,0x10,0x01]
>>> vinserti32x4  $1, 256(%rdi), %zmm28, %zmm17
>>> 
>>> -// CHECK: vinserti32x8
>>> -// CHECK: encoding: [0x62,0xd3,0x4d,0x40,0x3a,0xdb,0x01]
>>> -vinserti32x8  $1, %ymm11, %zmm22, %zmm3
>>> -
>>> -// CHECK: vinsertf64x2
>>> -// CHECK: encoding: [0x62,0xf3,0xed,0x48,0x18,0x4f,0x10,0x01]
>>> -vinsertf64x2  $1, 256(%rdi), %zmm2, %zmm1
>>> -
>>> // CHECK: vextracti32x4
>>> // CHECK: encoding: [0x62,0x33,0x7d,0x48,0x39,0xc9,0x01]
>>> vextracti32x4  $1, %zmm9, %xmm17
>>> @@ -5921,9 +5912,6 @@ vpcmpd $1, %zmm24, %zmm7, %k5{%k4} // CHECK: 
>>> encoding: [0x62,0xf3,0xf5,0x47,0x1e,0x72,0x01,0x02]
>>> vpcmpuq $2, 0x40(%rdx), %zmm17, %k6{%k7}
>>> 
>>> -// ERR: invalid operand for instruction -vpcmpd $1, %zmm24, %zmm7, 
>>> %k5{%k0}
>>> -
>> 
>> Why did you remove the test I added in r212504?!
>> 
>> I also don’t understand what this changes is doing.  Please add more detailed commit messages.
>> 
>> Adam
>> 
>>> // CHECK: vpermi2d
>>> // CHECK: encoding: [0x62,0x42,0x6d,0x4b,0x76,0xd6] vpermi2d %zmm14, 
>>> %zmm2, %zmm26 {%k3}
>>> 
>>> Modified: llvm/trunk/test/MC/X86/x86-64-avx512dq.s
>>> URL: 
>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/X86/x86-64-av
>>> x5 12dq.s?rev=236416&r1=236415&r2=236416&view=diff
>>> ====================================================================
>>> ==
>>> ========
>>> --- llvm/trunk/test/MC/X86/x86-64-avx512dq.s (original)
>>> +++ llvm/trunk/test/MC/X86/x86-64-avx512dq.s Mon May  4 06:09:41 
>>> +++ 2015
>>> @@ -1022,3 +1022,12 @@
>>> // CHECK: vxorps -516(%rdx){1to16}, %zmm28, %zmm24 // CHECK:  
>>> encoding: [0x62,0x61,0x1c,0x50,0x57,0x82,0xfc,0xfd,0xff,0xff]
>>>         vxorps -516(%rdx){1to16}, %zmm28, %zmm24
>>> +
>>> +// CHECK: vinserti32x8
>>> +// CHECK: encoding: [0x62,0xd3,0x4d,0x40,0x3a,0xdb,0x01]
>>> +          vinserti32x8  $1, %ymm11, %zmm22, %zmm3
>>> +
>>> +// CHECK: vinsertf64x2
>>> +// CHECK: encoding: [0x62,0xf3,0xed,0x48,0x18,0x4f,0x10,0x01]
>>> +          vinsertf64x2  $1, 256(%rdi), %zmm2, %zmm1
>>> +
>>> 
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>> ---------------------------------------------------------------------
>> Intel Israel (74) Limited
>> 
>> This e-mail and any attachments may contain confidential material for 
>> the sole use of the intended recipient(s). Any review or distribution 
>> by others is strictly prohibited. If you are not the intended 
>> recipient, please contact the sender and delete all copies.
> 

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.